lkml.org 
[lkml]   [2020]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff
Date
Jiafei Pan <Jiafei.Pan@nxp.com> writes:
> __raise_softirq_irqoff will update per-CPU mask of pending softirqs,

Please write __raise_softirq_irqoff() so it's clear that this is about a
function.

> void __raise_softirq_irqoff(unsigned int nr)
> {
> + /* This function can only be called in irq disabled context,
> + * otherwise or_softirq_pending will be interrupted by hardware
> + * interrupt, so that there will be unexpected issue.
> + */
> + WARN_ON_ONCE(!irqs_disabled());

Please use lockdep_assert_irqs_disabled() instead.

Thanks,

tglx

\
 
 \ /
  Last update: 2020-08-13 09:34    [W:0.070 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site