lkml.org 
[lkml]   [2020]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 1/4] scsi: ufs: Add UFS feature related parameter
From
Date
Hi Bart,

> On 2020-08-06 02:02, Daejun Park wrote:
> > @@ -537,6 +548,7 @@ struct ufs_dev_info {
> > u8 *model;
> > u16 wspecversion;
> > u32 clk_gating_wait_us;
> > + u8 b_ufs_feature_sup;
> > u32 d_ext_ufs_feature_sup;
> > u8 b_wb_buffer_type;
> > u32 d_wb_alloc_units;
> >
>
> Hmm ... shouldn't this variable be introduced in the patch that introduces
> the code that sets and uses this variable?

OK, I will move this variable to 2/4 patch.

> How about making it clear in the patch subject that this patch adds protocol
> constants related to HPB?

The subject will be changed :
"Add UFS feature related parameter -> Adds constants related to HPB"

> Otherwise this patch looks good to me.
>
> Bart.

Thanks,

Daejun

\
 
 \ /
  Last update: 2020-08-13 04:25    [W:0.120 / U:3.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site