lkml.org 
[lkml]   [2020]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] mmc: mediatek: add optional module reset property
From
Tested with these 2 changes below too.

Am 12. August 2020 14:08:19 MESZ schrieb Philipp Zabel <p.zabel@pengutronix.de>:

>> + if (!IS_ERR(host->reset)) {
>> + reset_control_assert(host->reset);
>> + usleep_range(10, 50);
>> + reset_control_deassert(host->reset);
>> + }
>> +
>
>This should be:
>
> if (host->reset) {
> reset_control_assert(host->reset);
> usleep_range(10, 50);
> reset_control_deassert(host->reset);
> }
>

>> + host->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
>> + "hrst");
>> + if (PTR_ERR(host->reset) == -EPROBE_DEFER)
>> + return PTR_ERR(host->reset);
>> +
>
>This should be:
>
> host->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
> "hrst");
> if (IS_ERR(host->reset))
> return PTR_ERR(host->reset);
>

>With these two changes,
>
>Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards Frank

\
 
 \ /
  Last update: 2020-08-12 22:01    [W:0.055 / U:8.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site