lkml.org 
[lkml]   [2020]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 02/18] gpio: uapi: define uAPI v2
On Tue, Aug 11, 2020 at 09:11:41PM +0200, Bartosz Golaszewski wrote:
> On Sun, Aug 9, 2020 at 3:26 PM Kent Gibson <warthog618@gmail.com> wrote:
> >
[snip]
> >
> > +/*
> > + * Maximum number of requested lines.
> > + *
> > + * Must be no greater than 64 as bitmaps are limited to 64-bits, and a
> > + * multiple of 2 to ensure 32/64-bit alignment of structs.
> > + */
> > +#define GPIO_V2_LINES_MAX 64
> > +
>
> If we refer to bitmaps for which helpers are defined in
> include/linux/bitmap.h then they're not limited to 64-bits. I'd just
> say here that we want to fit into 64-bit integers for simplicity.
>

Strictly speaking, userspace doesn't know about include/linux/bitmap.h,
but I'm happy to remove any ambiguity.

Does this work for you?:

* Must be no greater than 64, as bitmaps are restricted here to 64-bits
* for simplicity, and a multiple of 2 to ensure 32/64-bit alignment of
* structs.

Cheers,
Kent.

\
 
 \ /
  Last update: 2020-08-12 03:56    [W:0.073 / U:2.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site