[lkml]   [2020]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] KVM: X86: Move ignore_msrs handling upper the stack
On Thu, Jul 09, 2020 at 08:24:03PM +0200, Paolo Bonzini wrote:
> On 09/07/20 20:22, Peter Xu wrote:
> >>> So I think Peter's patch is fine, but (possibly on top as a third patch)
> >>> __must_check should be added to MSR getters and setters. Also one
> >>> possibility is to return -EINVAL for invalid MSRs.
> > Yeah I can add another patch for that. Also if to repost, I tend to also
> > introduce KVM_MSR_RET_[OK|ERROR] too, which seems to be cleaner when we had
> You can use either that or 0/1/-EINVAL. I would be fine with that to
> keep the patch small.

Yeah -EINVAL looks good. Then, do you want me to s/1/-EFAULT/ altogether?

Peter Xu

 \ /
  Last update: 2020-07-09 20:35    [W:0.044 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site