Messages in this thread |  | | Date | Thu, 9 Jul 2020 10:26:36 -0700 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH v8 1/2] usb: dwc3: qcom: Add interconnect support in dwc3 driver |
| |
Hi,
inline one more thing I forgot to comment on in my previous mail
On Thu, Jul 09, 2020 at 09:30:11PM +0530, Sandeep Maheswaram wrote: > Add interconnect support in dwc3-qcom driver to vote for bus > bandwidth. > > This requires for two different paths - from USB master to > DDR slave. The other is from APPS master to USB slave. > > Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org> > Signed-off-by: Chandana Kishori Chiluveru <cchiluve@codeaurora.org> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > --- > drivers/usb/dwc3/dwc3-qcom.c | 127 ++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 125 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index 1dfd024..5532988 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > > ... > > @@ -648,6 +763,11 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > goto depopulate; > } > > + qcom->max_speed = usb_get_maximum_speed(&qcom->dwc3->dev);
What if the function returns USB_SPEED_UNKNOWN?
You need a reasonable default value for that case, which I think would be USB_SPEED_SUPER (i.e. the controller would work properly at super speed, though the interconnects would consume a bit more power than necessary lower speed modes).
|  |