lkml.org 
[lkml]   [2020]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernel/smp: Fix an off by one in csd_lock_wait_toolong()
On Thu, Jul 09, 2020 at 01:49:00PM +0200, Sebastian Andrzej Siewior wrote:
> On 2020-07-09 12:59:06 [+0200], Peter Zijlstra wrote:
> > On Thu, Jul 09, 2020 at 01:48:18PM +0300, Dan Carpenter wrote:
> > > The __per_cpu_offset[] array has "nr_cpu_ids" elements so change the >
> > > >= to prevent a read one element beyond the end of the array.
> > >
> > > Fixes: 0504bc41a62c ("kernel/smp: Provide CSD lock timeout diagnostics")
> >
> > I don't have a copy of that patch in my inbox, even though it says Cc:
> > me.
> >
> > Paul, where do you expect that patch to go? The version I see from my
> > next tree needs a _lot_ of work.
>
> There is also
>
> https://lkml.kernel.org/r/20200705082603.GX3874@shao2-debian
> https://lkml.kernel.org/r/00000000000042f21905a991ecea@google.com
>
> it might be the same thing.

Same commit, different bug, but the fix should be in -next by now.
For these two reports, the problem was that I had debug-recording code
on the wrong side of a csd_unlock().

Thanx, Paul

\
 
 \ /
  Last update: 2020-07-09 16:37    [W:0.044 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site