Messages in this thread |  | | Subject | Re: [PATCH v3 6/8] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node | From | Srinivas Kandagatla <> | Date | Thu, 9 Jul 2020 11:14:18 +0100 |
| |
On 09/07/2020 11:12, Rohit Kumar wrote: > > On 7/9/2020 3:38 PM, Srinivas Kandagatla wrote: >> >> >> On 09/07/2020 11:01, Rohit Kumar wrote: >>> >>> On 7/9/2020 2:57 PM, Srinivas Kandagatla wrote: >>>> >>>> >>>> On 08/07/2020 06:08, Rohit kumar wrote: >>>>> Add dt-bindings to support "qcom,lpass-cpu-sc7180" node. >>>>> >>>>> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org> >>>>> --- >>>>> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt >>>>> b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt >>>>> index 32c2cdb..04e34cc 100644 >>>>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt >>>>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt >>>>> @@ -4,7 +4,8 @@ This node models the Qualcomm Technologies >>>>> Low-Power Audio SubSystem (LPASS). >>>>> Required properties: >>>>> -- compatible : "qcom,lpass-cpu" or "qcom,apq8016-lpass-cpu" >>>>> +- compatible : "qcom,lpass-cpu" or "qcom,apq8016-lpass-cpu" or >>>>> + "qcom,lpass-cpu-sc7180" >>>>> - clocks : Must contain an entry for each entry in >>>>> clock-names. >>>>> - clock-names : A list which must include the following >>>>> entries: >>>>> * "ahbix-clk" >>>> >>>> Can you also list the clocks that are mandatory for this SoC. >>>> >>>> --srini >>>> >>> Will it be fine if I update it in patch 8 only where we have moved to >>> yaml format? >>> >> May be reverse the order, Convert to Yaml first and then add sc7180! > > Actually Mark suggested to keep yaml change at the end of patch series > as there > > are pending yaml patch reviews and it might take time. If we keep yaml > change before sc7180 > > change, then it will get blocked until yaml review. For now, I can > update in exisiting > > documentation. Please suggest. Then these clocks need to be documented in this patch itself!
--srini > > Thanks > >> >> --srini >>> Thanks, >>> >>> Rohit >>> >>>> >>>>>
|  |