Messages in this thread |  | | From | Justin He <> | Subject | RE: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory | Date | Thu, 9 Jul 2020 09:36:42 +0000 |
| |
Hi David
> -----Original Message----- > From: David Hildenbrand <david@redhat.com> > Sent: Thursday, July 9, 2020 5:19 PM > To: Mike Rapoport <rppt@linux.ibm.com>; Matthew Wilcox > <willy@infradead.org> > Cc: Justin He <Justin.He@arm.com>; Catalin Marinas > <Catalin.Marinas@arm.com>; Will Deacon <will@kernel.org>; Tony Luck > <tony.luck@intel.com>; Fenghua Yu <fenghua.yu@intel.com>; Yoshinori Sato > <ysato@users.sourceforge.jp>; Rich Felker <dalias@libc.org>; Dave Hansen > <dave.hansen@linux.intel.com>; Andy Lutomirski <luto@kernel.org>; Peter > Zijlstra <peterz@infradead.org>; Thomas Gleixner <tglx@linutronix.de>; > Ingo Molnar <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; > x86@kernel.org; H. Peter Anvin <hpa@zytor.com>; Dan Williams > <dan.j.williams@intel.com>; Vishal Verma <vishal.l.verma@intel.com>; Dave > Jiang <dave.jiang@intel.com>; Andrew Morton <akpm@linux-foundation.org>; > Baoquan He <bhe@redhat.com>; Chuhong Yuan <hslester96@gmail.com>; Logan > Gunthorpe <logang@deltatee.com>; Masahiro Yamada <masahiroy@kernel.org>; > Michal Hocko <mhocko@suse.com>; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-ia64@vger.kernel.org; linux- > sh@vger.kernel.org; linux-nvdimm@lists.01.org; linux-mm@kvack.org; > Jonathan Cameron <Jonathan.Cameron@huawei.com>; Kaly Xin <Kaly.Xin@arm.com> > Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in > arch specific directory > > On 09.07.20 11:18, Mike Rapoport wrote: > > On Thu, Jul 09, 2020 at 03:11:04AM +0100, Matthew Wilcox wrote: > >> On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > >>> After a general version of __weak memory_add_physaddr_to_nid > implemented > >>> and exported , it is no use exporting twice in arch directory even if > >>> e,g, ia64/x86 have their specific version. > >>> > >>> This is to suppress the modpost warning: > >>> WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > >>> Previous export was in vmlinux > >> > >> It's bad form to introduce a warning and then send a follow-up patch to > >> fix the warning. Just fold this patch into patch 1/6. > > > > Moreover, I think that patches 1-4 can be merged into one. > > > > +1
Okay, will update, thanks
-- Cheers, Justin (Jia He)
|  |