Messages in this thread |  | | Date | Thu, 9 Jul 2020 09:32:49 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH v3 1/4] iomap: Constify ioreadX() iomem argument (as in generic implementation) |
| |
On Thu, Jul 09, 2020 at 09:28:34AM +0200, Krzysztof Kozlowski wrote: > The ioreadX() and ioreadX_rep() helpers have inconsistent interface. On > some architectures void *__iomem address argument is a pointer to const, > on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I forgot to put here one more Ack, for PowerPC: Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
https://lore.kernel.org/lkml/87ftedj0zz.fsf@mpe.ellerman.id.au/
Best regards, Krzysztof
|  |