Messages in this thread |  | | Subject | Re: [PATCH V4] mm/vmstat: Add events for THP migration without split | From | Anshuman Khandual <> | Date | Fri, 10 Jul 2020 09:00:09 +0530 |
| |
On 07/09/2020 09:04 PM, Randy Dunlap wrote: > Hi, > > I have a few comments on this. > > a. I reported it very early and should have been Cc-ed.
I should have Cc-ed you on this V4 patch, sorry about that.
> > b. A patch that applies to mmotm or linux-next would have been better > than a full replacement patch. I have followed that (i.e patch on mmotm/next as fix) only when the required change is smaller as compared to the series on mmotm/next. But for others a new patch should be better which can be replaced on mmotm and next. At least that is my understanding and would like to be corrected otherwise.
> > c. I tried replacing what I believe is the correct/same patch file in mmotm > and still have build errors.
That should not have happened, all new THP migration events are with CONFIG_MIGRATION rather than CONFIG_TRANSPARENT_HUGEPAGE previously.
|  |