Messages in this thread |  | | From | Andy Shevchenko <> | Date | Thu, 9 Jul 2020 22:54:55 +0300 | Subject | Re: [PATCH v2] ACPI / platform: Fix return value check in check_acpi_dev() |
| |
On Fri, Jun 5, 2020 at 2:42 PM Lu Wei <luwei32@huawei.com> wrote: > > In the function check_acpi_dev(), if it fails to create > platform device, the return value is ERR_PTR() or NULL. Thus it must > use IS_ERR_OR_NULL to check return value. >
Thanks!
> Fixes: ecc83e52b28c (intel-hid: new hid event driver for hotkeys)
This is not the correct format. Please, fix it in the next version, thanks!
> drivers/platform/x86/intel-hid.c | 2 +- > drivers/platform/x86/intel-vbtn.c | 2 +-
Please, split per driver.
-- With Best Regards, Andy Shevchenko
|  |