Messages in this thread |  | | Date | Mon, 6 Jul 2020 22:31:28 -0400 | From | Alyssa Rosenzweig <> | Subject | Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit |
| |
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
On Sun, Jun 14, 2020 at 01:27:30AM -0500, Navid Emamdoost wrote: > in panfrost_job_hw_submit, pm_runtime_get_sync is called which > increments the counter even in case of failure, leading to incorrect > ref count. In case of failure, decrement the ref count before returning. > > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> > --- > drivers/gpu/drm/panfrost/panfrost_job.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c > index 7914b1570841..89ac84667eb1 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_job.c > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c > @@ -147,11 +147,10 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js) > > ret = pm_runtime_get_sync(pfdev->dev); > if (ret < 0) > - return; > + goto out; > > if (WARN_ON(job_read(pfdev, JS_COMMAND_NEXT(js)))) { > - pm_runtime_put_sync_autosuspend(pfdev->dev); > - return; > + goto out; > } > > cfg = panfrost_mmu_as_get(pfdev, &job->file_priv->mmu); > @@ -184,6 +183,9 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js) > job, js, jc_head); > > job_write(pfdev, JS_COMMAND_NEXT(js), JS_COMMAND_START); > +out: > + pm_runtime_put_sync_autosuspend(pfdev->dev); > + return; > } > > static void panfrost_acquire_object_fences(struct drm_gem_object **bos, > -- > 2.17.1 >
|  |