Messages in this thread |  | | From | Arnd Bergmann <> | Date | Sat, 25 Jul 2020 09:57:41 +0200 | Subject | Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy |
| |
On Fri, Jul 24, 2020 at 11:57 PM santosh.shilimkar@oracle.com <santosh.shilimkar@oracle.com> wrote: > On 7/24/20 2:42 PM, Grygorii Strashko wrote: > > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the > > KSZ9031 PHY") the networking is broken on keystone-k2g-evm board. > > > > The above board have phy-mode = "rgmii-id" and it is worked before because > > KSZ9031 PHY started with default RGMII internal delays configuration (TX > > off, RX on 1.2 ns) and MAC provided TX delay by default. > > After above commit, the KSZ9031 PHY starts handling phy mode properly and > > enables both RX and TX delays, as result networking is become broken. > > > > Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous > > behavior. > > > > Cc: Oleksij Rempel <o.rempel@pengutronix.de> > > Cc: Andrew Lunn <andrew@lunn.ch> > > Cc: Philippe Schenker <philippe.schenker@toradex.com> > > Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > > --- > > Fix for one more broken TI board with KSZ9031 PHY. > Can you please apply this patch to your v5.8 fixes branch and send it > upstream ? Without the fix K2G EVM board is broken with v5.8. > > Am hoping you can pick this up with pull request since it just one > patch.
I've applied it now, but would point out that it's generally better if you could forward the patch to soc@kernel.org with your Signed-off-by if you come across a similar patch again. That way it ends up in patchwork, and we are more likely to pick it up quickly.
Arnd
|  |