Messages in this thread |  | | Subject | Re: [PATCH v3 00/19] Introduce partial kernel_read_file() support | From | Scott Branden <> | Date | Fri, 24 Jul 2020 22:14:23 -0700 |
| |
On 2020-07-24 2:36 p.m., Kees Cook wrote: > v3: > - add reviews/acks > - add "IMA: Add support for file reads without contents" patch > - trim CC list, in case that's why vger ignored v2 > v2: [missing from lkml archives! (CC list too long?) repeating changes here] > - fix issues in firmware test suite > - add firmware partial read patches > - various bug fixes/cleanups > v1: https://lore.kernel.org/lkml/20200717174309.1164575-1-keescook@chromium.org/ > > Hi, > > Here's my tree for adding partial read support in kernel_read_file(), > which fixes a number of issues along the way. It's got Scott's firmware > and IMA patches ported and everything tests cleanly for me (even with > CONFIG_IMA_APPRAISE=y). > > I think the intention is for this to go via Greg's tree since Scott's > driver code will depend on it? v3 of this patch series looks good and passes all of my tests. Remaining patches Acked-by: Scott Branden <scott.branden@broadcom.com>
I have added latest bcm-vk driver code to Kees' patch series and added it here: https://github.com/sbranden/linux/tree/kernel_read_file_for_kees_v3
If everyone finds Kees' patch series acceptable then the 3 patches adding the bcm-vk driver need to be added to the series. I can send the 3 patches out separately and then the two patch series can be combined in Greg or someone's tree if that works? Or if an in-kernel user beyond kernel selftest is needed for request_partial_firmware_into_buf in Kees' patch series then another PATCH v4 needs to be sent out including the bcm-vk driver. > > Thanks, > > -Kees > > > Kees Cook (15):
Thanks for help Kees, it's works now. > test_firmware: Test platform fw loading on non-EFI systems > selftest/firmware: Add selftest timeout in settings > firmware_loader: EFI firmware loader must handle pre-allocated buffer > fs/kernel_read_file: Remove FIRMWARE_PREALLOC_BUFFER enum > fs/kernel_read_file: Remove FIRMWARE_EFI_EMBEDDED enum > fs/kernel_read_file: Split into separate source file > fs/kernel_read_file: Remove redundant size argument > fs/kernel_read_file: Switch buffer size arg to size_t > fs/kernel_read_file: Add file_size output argument > LSM: Introduce kernel_post_load_data() hook > firmware_loader: Use security_post_load_data() > module: Call security_kernel_post_load_data() > LSM: Add "contents" flag to kernel_read_file hook > fs/kernel_file_read: Add "offset" arg for partial reads > firmware: Store opt_flags in fw_priv > > Scott Branden (4): > fs/kernel_read_file: Split into separate include file > IMA: Add support for file reads without contents > firmware: Add request_partial_firmware_into_buf() > test_firmware: Test partial read support > > drivers/base/firmware_loader/fallback.c | 19 +- > drivers/base/firmware_loader/fallback.h | 5 +- > .../base/firmware_loader/fallback_platform.c | 16 +- > drivers/base/firmware_loader/firmware.h | 7 +- > drivers/base/firmware_loader/main.c | 143 ++++++++++--- > drivers/firmware/efi/embedded-firmware.c | 21 +- > drivers/firmware/efi/embedded-firmware.h | 19 ++ > fs/Makefile | 3 +- > fs/exec.c | 132 +----------- > fs/kernel_read_file.c | 189 ++++++++++++++++++ > include/linux/efi_embedded_fw.h | 13 -- > include/linux/firmware.h | 12 ++ > include/linux/fs.h | 39 ---- > include/linux/ima.h | 19 +- > include/linux/kernel_read_file.h | 55 +++++ > include/linux/lsm_hook_defs.h | 6 +- > include/linux/lsm_hooks.h | 12 ++ > include/linux/security.h | 19 +- > kernel/kexec.c | 2 +- > kernel/kexec_file.c | 19 +- > kernel/module.c | 24 ++- > lib/test_firmware.c | 159 +++++++++++++-- > security/integrity/digsig.c | 8 +- > security/integrity/ima/ima_fs.c | 10 +- > security/integrity/ima/ima_main.c | 70 +++++-- > security/integrity/ima/ima_policy.c | 1 + > security/loadpin/loadpin.c | 17 +- > security/security.c | 26 ++- > security/selinux/hooks.c | 8 +- > .../selftests/firmware/fw_filesystem.sh | 91 +++++++++ > tools/testing/selftests/firmware/settings | 8 + > tools/testing/selftests/kselftest/runner.sh | 6 +- > 32 files changed, 860 insertions(+), 318 deletions(-) > create mode 100644 drivers/firmware/efi/embedded-firmware.h > create mode 100644 fs/kernel_read_file.c > create mode 100644 include/linux/kernel_read_file.h > create mode 100644 tools/testing/selftests/firmware/settings >
|  |