Messages in this thread Patch in this message |  | | From | John Oldman <> | Subject | [PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone | Date | Sat, 25 Jul 2020 15:37:12 +0100 |
| |
clear below issues reported by checkpatch.pl:
CHECK: Using comparison to true is error prone
Signed-off-by: John Oldman <john.oldman@polehill.co.uk> --- v1- First attempt: removed comparison to true. v2- Removed unneccessary parentheses around 'pregistrypriv->ht_enable, missed in v1. v3- Corrected the 'odd' subject line; moved the || and && to the end of the line.
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c index ca98274ae390..46fad71197b6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -363,8 +363,9 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv) }
/* HT Cap. */ - if (((pregistrypriv->wireless_mode&WIRELESS_11_5N) || (pregistrypriv->wireless_mode&WIRELESS_11_24N)) - && (pregistrypriv->ht_enable == true)) { + if (((pregistrypriv->wireless_mode & WIRELESS_11_5N) || + (pregistrypriv->wireless_mode & WIRELESS_11_24N)) && + pregistrypriv->ht_enable) { /* todo: */ }
-- 2.17.1
|  |