[lkml]   [2020]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] ARM: milbeaut: Add missing of_node_put() call in m10v_smp_init()
> The variable np in function m10v_smp_init takes the return value
> of of_find_compatible_node, which gets a node but does not put it.

Such information is useful.

> If this node is not put it may cause a memory leak.

Is the reference management generally improvable for this function implementation?

Will the tag “Fixes” become helpful for the commit message?


 \ /
  Last update: 2020-07-25 14:03    [W:0.022 / U:2.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site