[lkml]   [2020]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ipv6: Fix nexthop reference count in ip6_route_info_create()

> When ip6_route_info_create() returns, local variable "nh" becomes
> invalid, so the refcount should be decreased to keep refcount balanced.

Can it be helpful to use the term “reference count” in consistent ways?

> Fix this issue

How do you think about to replace this wording by the tag “Fixes”?

> by pulling up the error source routing handling when
> nexthops can not be used with source routing.

Does the movement of an if statement according to the check of the
data structure member “rt->fib6_src.plen” in an if branch really help here?


 \ /
  Last update: 2020-07-25 11:35    [W:0.025 / U:3.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site