Messages in this thread Patch in this message |  | | From | Li Heng <> | Subject | [PATCH] nbd: add missed destroy_workqueue when nbd_start_device fails | Date | Sat, 25 Jul 2020 10:27:50 +0800 |
| |
destroy_workqueue() should be called to destroy ndev->tx_wq when nbd_start_device init resources fails.
Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Li Heng <liheng40@huawei.com> --- drivers/block/nbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index ce7e9f22..45e0a9f4 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -4,7 +4,7 @@ * * Note that you can not swap over this thing, yet. Seems to work but * deadlocks sometimes - you can not swap over TCP in general. - * + * * Copyright 1997-2000, 2008 Pavel Machek <pavel@ucw.cz> * Parts copyright 2001 Steven Whitehouse <steve@chygwyn.com> * @@ -1270,6 +1270,7 @@ static int nbd_start_device(struct nbd_device *nbd) error = device_create_file(disk_to_dev(nbd->disk), &pid_attr); if (error) { dev_err(disk_to_dev(nbd->disk), "device_create_file failed!\n"); + destroy_workqueue(nbd->recv_workq); return error; } set_bit(NBD_RT_HAS_PID_FILE, &config->runtime_flags); @@ -1291,6 +1292,7 @@ static int nbd_start_device(struct nbd_device *nbd) */ if (i) flush_workqueue(nbd->recv_workq); + destroy_workqueue(nbd->recv_workq); return -ENOMEM; } sk_set_memalloc(config->socks[i]->sock->sk); -- 2.7.4
|  |