Messages in this thread |  | | Date | Fri, 10 Jul 2020 11:03:44 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH RFC] kprobes: Remove MODULES dependency |
| |
On Fri, Jul 10, 2020 at 02:45:19AM +0300, Jarkko Sakkinen wrote: > Remove MODULES dependency and migrate from module_alloc to vmalloc(). > According to Andi, the history with this dependency is that kprobes > originally required custom LKM's, which does not hold today anymore. > > Right now one has to compile LKM support only to enable kprobes. With > this change applied, it is somewhat easier to create custom test > kernel's with a proper debugging capabilities, thus making Linux more > developer friendly. > > Cc: Andi Kleen <ak@linux.intel.com> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
NAK
this patch is horrific, it sprinkles a metric ton of #ifdef and silently disables a lot of kprobe features (like all the opt stuff).
How about unconditionally providing module_alloc() instead?
|  |