lkml.org 
[lkml]   [2020]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] dma-pool: Get rid of dma_in_atomic_pool()
On Thu, Jul 09, 2020 at 02:51:13PM -0700, David Rientjes wrote:
> On Thu, 9 Jul 2020, Nicolas Saenz Julienne wrote:
>
> > The function is only used once and can be simplified to a one-liner.
> >
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> I'll leave this one to Christoph to decide on. One thing I really liked
> about hacking around in kernel/dma is the coding style, it really follows
> "one function does one thing and does it well" even if there is only one
> caller. dma_in_atomic_pool() was an attempt to follow in those footsteps.

While I like the helper aswell, I don't see how it could work nicely
with the changes in patch 4.

\
 
 \ /
  Last update: 2020-07-10 08:51    [W:0.076 / U:1.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site