Messages in this thread |  | | Subject | Re: [PATCH v2] usb: mtu3: Fix NULL pointer dereferences | From | Markus Elfring <> | Date | Tue, 30 Jun 2020 12:47:03 +0200 |
| |
> Some pointers are dereferenced before successful checks.
I propose to reconsider and improve also this change description.
* Would a null pointer dereference be possible only with the variables “mep” and “mreq” in the implementation of the function “mtu3_gadget_dequeue”? (Can it make sense to split the patch according to this detail?)
* How do you think about to convert any more variable initialisations to later assignments?
* Will it become helpful to add the tag “Fixes” to the commit message?
… > --- > v2: nothing changed, but abandon another patch
Are there chances to take any previous patch review comments better into account (besides the shown reduction of update steps)?
> --- > drivers/usb/mtu3/mtu3_gadget.c | 25 ++++++++++++++++++-------
I suggest to replace the triple dashes before this diffstat by a blank line.
Regards, Markus
|  |