Messages in this thread |  | | Date | Wed, 17 Jun 2020 17:00:48 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next v7 6/6] net: phy: DP83822: Add ability to advertise Fiber connection |
| |
On Wed, 17 Jun 2020 13:20:19 -0500 Dan Murphy wrote: > +static int dp83822_config_init(struct phy_device *phydev) > +{ > + struct dp83822_private *dp83822 = phydev->priv; > + int rgmii_delay; > + int err = 0; > + > + if (phy_interface_is_rgmii(phydev)) { > + if (dp83822->rx_int_delay) > + rgmii_delay = DP83822_RX_CLK_SHIFT; > + > + if (dp83822->tx_int_delay) > + rgmii_delay |= DP83822_TX_CLK_SHIFT; > + > + if (rgmii_delay) > + err = phy_set_bits_mmd(phydev, DP83822_DEVADDR, > + MII_DP83822_RCSR, rgmii_delay); > + } > + > + return dp8382x_disable_wol(phydev); > +}
drivers/net/phy/dp83822.c: In function dp83822_config_init: drivers/net/phy/dp83822.c:282:6: warning: variable err set but not used [-Wunused-but-set-variable] 282 | int err = 0; | ^~~
|  |