lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 2/3] venus: Make debug infrastructure more flexible
From
Date
Hi Greg,

On 6/14/20 9:37 AM, Greg KH wrote:
> On Sun, Jun 14, 2020 at 01:39:18AM +0300, Stanimir Varbanov wrote:
>> if (slot == -1) {
>> - dev_dbg(inst->core->dev, "%s: no free slot\n", __func__);
>> + VDBGH("no free slot for timestamp\n");
>
> Again, no, you just lost a lot of valuable information by changing to a
> different format (like driver, specific device, etc.). Please don't do
> this, it just makes the information less than before.

OK, one of the reasons to use pr_debug inside VDBGH macro is to avoid
having struct device *dev variable in every function with dev_dbg even
when the function doesn't use it.

Are you fine with s/pr_debug/dev_dbg in VDBGX macros?

--
regards,
Stan

\
 
 \ /
  Last update: 2020-06-15 11:56    [W:0.054 / U:0.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site