lkml.org 
[lkml]   [2020]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v10 1/4] dt-bindings: media: i2c: Add bindings for Maxim Integrated MAX9286
    Hi Rob,

    On Fri, Jun 12, 2020 at 04:10:03PM -0600, Rob Herring wrote:
    > On Fri, 12 Jun 2020 15:47:10 +0100, Kieran Bingham wrote:
    > > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
    > >
    > > The MAX9286 deserializes video data received on up to 4 Gigabit
    > > Multimedia Serial Links (GMSL) and outputs them on a CSI-2 port using up
    > > to 4 data lanes.
    > >
    > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
    > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
    > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
    > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
    > > Reviewed-by: Rob Herring <robh@kernel.org>
    > >
    > > ---
    > >
    > > v7:
    > > - Collect Rob's RB tag
    > > - Remove redundant maxItems from remote-endpoints
    > > - Fix SPDX licence tag
    > >
    > > v10:
    > > [Jacopo]
    > > - Fix dt-validation
    > > - Fix dt-binding examples with 2 reg entries
    > >
    > > [Kieran]
    > > - Correctly match the hex camera node reg
    > > - Add (required) GPIO controller support
    > >
    > > .../bindings/media/i2c/maxim,max9286.yaml | 366 ++++++++++++++++++
    > > 1 file changed, 366 insertions(+)
    > > create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
    > >
    >
    >
    > My bot found errors running 'make dt_binding_check' on your patch:
    >
    > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/maxim,max9286.example.dt.yaml: example-0: i2c@e66d8000:reg:0: [0, 3865935872, 0, 64] is too long
    >
    >
    > See https://patchwork.ozlabs.org/patch/1308280
    >
    > If you already ran 'make dt_binding_check' and didn't see the above
    > error(s), then make sure dt-schema is up to date:
    >
    > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
    >

    I have updated my dt-schema installation to the latest github master
    -------------------------------------------------------------------------------
    Successfully installed dtschema-2020.6.dev8+g4d2d86c

    https://github.com/devicetree-org/dt-schema/commit/4d2d86c5cd65cd3944ce0aaa400866bc36727bea

    $ /usr/bin/dt-validate -V
    2020.6.dev8+g4d2d86c
    -------------------------------------------------------------------------------

    But I still cannot reproduce the error.

    However, I see this commit in your next branch
    https://github.com/devicetree-org/dt-schema/commit/b72500282cfd2eba6f9df4d7553f696544b40ee6
    "schemas: Add a schema to check 'reg' sizes "

    Which sounds very likely related to the above reported error.
    Was this intentional ?

    I'm not sure how I should handle this. The error reports the i2c node
    parents should have both address-cells and size-cells properties set
    to 2, but in the example there is not i2c node parent at all :)
    Should I add a parent node for the i2c in the example snippet ?

    Thanks
    j

    > Please check and re-submit.
    >

    \
     
     \ /
      Last update: 2020-06-13 14:29    [W:27.132 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site