lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] lan743x: Added fixed_phy support / Question regarding proper devicetree
From
Date
Working status: I added fixed_phy support to the Microchip lan743x ethernet driver and for upstream contribution I need to make it runtime configurable via the device tree.

Question:

There are, amongst other, the following devices on my target (i.mx6):
/soc/aips-bus@2100000/ethernet@2188000
/soc/pcie@1ffc000

Where would I put my additional lan743x ethernet device in the device tree ?

a) /ethernet@0
(Just a new root node.

b) /pci@0/ethernet@0
(I would „invent“ pci@0 to reflect that the lan7431 is sitting on the first pci slot.

c) /soc/pcie@1ffc000/ethernet@0
(That doesn’t feel right to me, it’s not a soc property. Or is it ?

Example:

pci0 {
ethernet@0 {
compatible = "rmtl-meu-hl“;
status = "okay“;
phy-connection-type = "rgmii“;

fixed-link {
speed = <100>;
full-duplex;
};
};

}

Thanks a lot,
Roelof

>
>> […] device tree is the way to go. […]
>>
>> Andrew
>

\
 
 \ /
  Last update: 2020-05-01 20:15    [W:0.074 / U:3.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site