Messages in this thread |  | | From | Rob Herring <> | Date | Thu, 9 Apr 2020 17:09:59 -0600 | Subject | Re: [PATCH v6 1/2] dt-bindings: serial: Add reg-io-width compatible |
| |
On Mon, Apr 6, 2020 at 5:09 PM Hyunki Koo <hyunki00.koo@samsung.com> wrote: > > Add a description for reg-io-width options for the samsung serial > UART peripheral. > > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com> > --- > v5: first added in this series > v6: clean description of reg-io-width > --- > Documentation/devicetree/bindings/serial/samsung_uart.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml > index 9d2ce347875b..1a0bb7619e2e 100644 > --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml > +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml > @@ -29,6 +29,12 @@ properties: > reg: > maxItems: 1 > > + reg-io-width: > + description: > + The size (in bytes) of the IO accesses that should be performed > + on the device. If omitted, default of 1 is used. > + - enum: [ 1, 4 ]
Can't this be implied by the compatible strings?
This isn't actual json-schema either with the enum under the description. Run 'make dt_binding_check' before you send schemas.
There's a keyword for expressing the default value too. Hint: It's 'default'.
Rob
|  |