Messages in this thread |  | | Date | Wed, 8 Apr 2020 09:11:52 -0700 | From | Jacob Pan <> | Subject | Re: [PATCH v11 02/10] iommu/uapi: Define a mask for bind data |
| |
On Wed, 8 Apr 2020 15:07:22 +0200 Joerg Roedel <joro@8bytes.org> wrote:
> On Fri, Apr 03, 2020 at 11:42:06AM -0700, Jacob Pan wrote: > > Memory type related flags can be grouped together for one simple > > check. > > > > --- > > v9 renamed from EMT to MTS since these are memory type support > > flags. --- > > > > Reviewed-by: Eric Auger <eric.auger@redhat.com> > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> > > --- > > include/uapi/linux/iommu.h | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/include/uapi/linux/iommu.h b/include/uapi/linux/iommu.h > > index 4ad3496e5c43..d7bcbc5f79b0 100644 > > --- a/include/uapi/linux/iommu.h > > +++ b/include/uapi/linux/iommu.h > > @@ -284,7 +284,10 @@ struct iommu_gpasid_bind_data_vtd { > > __u32 pat; > > __u32 emt; > > }; > > - > > +#define IOMMU_SVA_VTD_GPASID_MTS_MASK > > (IOMMU_SVA_VTD_GPASID_CD | \ > > + IOMMU_SVA_VTD_GPASID_EMTE > > | \ > > + IOMMU_SVA_VTD_GPASID_PCD > > | \ > > + > > IOMMU_SVA_VTD_GPASID_PWT) > > Where and how will this be used? Can you add this in the patch that > actually makes use of it? > They are used in later patch when setting up PASID entry for guest SVA. [PATCH v11 04/10] iommu/vt-d: Add nested translation helper function
> Also please add newlines before and after that define. > Will do, thanks.
> > Regards, > > Joerg
[Jacob Pan]
|  |