[lkml]   [2020]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 5/7] x86/mce: Change default mce logger to check mce->kflags
On Tue, Apr 07, 2020 at 04:43:29PM +0000, Luck, Tony wrote:
> >> + if (m->kflags)
> >> + pr_emerg(HW_ERR "kflags = 0x%llx\n", m->kflags);
> >
> > I've zapped that hunk. I'd like to avoid exposing those kflags to
> > luserspace in any shape or form for now.
> Sure. It was useful while I was debugging. But I'm sure all the bugs are
> gone now :-)

Do you need it for debugging?

If yes, it should be really clear that it is a debugging print and
nothing should rely on it. We could do a cmdline-param controllable
debugging scheme which tools cannot mistakenly start using and it
becomes an ABI, all of a sudden.


 \ /
  Last update: 2020-04-07 21:37    [W:0.087 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site