Messages in this thread |  | | Subject | Re: [PATCH] perf script: add flamegraph.py script | From | Kim Phillips <> | Date | Mon, 6 Apr 2020 09:27:49 -0500 |
| |
On 4/2/20 8:04 AM, Andreas Gerstmayr wrote: > On 26.03.20 20:04, Kim Phillips wrote: >> I now get a SIGSEGV when executing perf script report flamegraph. >> >> Here's a trace: >> >> #0 0x000055555590a9b2 in regs_map (regs=0x7fffffffbfc8, mask=16715775, >> bf=0x7fffffffba60 "", size=512) at util/scripting-engines/trace-event-python.c:696 >> #1 0x000055555590ab03 in set_regs_in_dict (dict=0x7ffff61dd500, sample=0x7fffffffbf20, >> evsel=0x555555d7a700) at util/scripting-engines/trace-event-python.c:718 > > This error seems unrelated to flamegraph.py (occurs also with the stackcollapse.py script). > > Looks like the intr_regs->regs can be 0 when running in DWARF mode (this error doesn't occur in the default mode). I've added a check and sent a patch. While at it, valgrind reported an invalid read in a different code path, which is fixed by the other patch I just sent a few minutes ago. > > Can you please test again and report if there are any other issues?
This flamegraph patch works for me now:
Tested-by: Kim Phillips <kim.phillips@amd.com>
Thanks,
Kim
|  |