[lkml]   [2020]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v15 5/7] soc: qcom: rpmh: Invoke rpmh_flush() for dirty caches

On 4/3/2020 1:43 AM, Doug Anderson wrote:
> Hi,
> On Tue, Mar 31, 2020 at 6:20 AM Maulik Shah <> wrote:
>> +/**
>> + * rpmh_rsc_ctrlr_is_busy: Check if any of the AMCs are busy.
> nit: this is still not quite kerneldoc format. Specifically, the
> above should be:
> * rpmh_rsc_ctrlr_is_busy() - Check if any of the AMCs are busy
> You may think I'm being nit picky, but try running:
> scripts/kernel-doc -rst drivers/soc/qcom/rpmh-rsc.c
> Now search the output for "Check if any of the AMCs are busy". It
> won't be there as you have formatted it. If you fix it to the proper
> format then it shows up. I'm not saying that you should fix up all
> functions at once but if you're adding new functions why not make them
> compliant?
> Other than the kerneldoc nitpick which could happen later in a cleanup
> series for the whole driver at once, this patch looks fine to me now.
> Reviewed-by: Douglas Anderson <>

Thanks for the review Doug.

I will fix this in v16 to update as per kernel doc format.


QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

 \ /
  Last update: 2020-04-06 06:52    [W:0.068 / U:5.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site