lkml.org 
[lkml]   [2020]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net] skbuff.h: Improve the checksum related comments
Date
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Sunday, April 5, 2020 9:41 AM
> To: Dexuan Cui <decui@microsoft.com>; Matthew Wilcox
> >> Why the capitalisation of 'AND'?
> > ...
> > The comma after the "CHECKSUM_PARTIAL" seems suspicious to me. I feel
> > we should add an "and" after the comma, or replace the comma with "and",
> > but either way we'll have "... and csum_start and csum_offset...", which
> > seems a little unnatural to me since we have 2 'and's here... So I tried to
> > make it a little natural by replacing the first 'and' with 'AND', which
> > obviously causes confusion to you.
>
> maybe "both csum_start and csum_offset are set to refer to".
> ~Randy

Looks good. I'll post a v2 shortly. Thank you both!

Thanks,
-- Dexuan
\
 
 \ /
  Last update: 2020-04-06 03:25    [W:0.059 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site