lkml.org 
[lkml]   [2020]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v4] tty: samsung_tty: 32-bit access for TX/RX hold registers
Date
On Fri, Apr 03, 2020 at 9:00: 10PM +0900, Krzysztof Kozlowski wrote:
> On Fri, Apr 03, 2020 at 08:15:10PM +0900, Hyunki Koo wrote:
> > Support 32-bit access for the TX/RX hold registers UTXH and URXH.
> >
> > This is required for some newer SoCs.
> >
> > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
> > ---
> > v2:
> > line 954 : change rd_regl to rd_reg in for backward compatibility.
>
> I did not see any change around line 954 in v1... so what was it?
954 line is changed like below.
V1 : rd_regb --> rd_regl : we thought, this register need to change to
V2: rd_regl --> rd_reg : we discuss internally, and
I decided not to change to existing devices for backward compatibility.
So we changed to rd_reg.
>
> Rest looks good for me, although you should address Greg's comments.
>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Tested on Odroid
> HC1 (Exynos5422):
> Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Best regards,
> Krzysztof


\
 
 \ /
  Last update: 2020-04-05 23:36    [W:0.119 / U:31.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site