lkml.org 
[lkml]   [2020]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] crypto: sun8i-ss - Delete an error message in sun8i_ss_probe()
On Sat, Apr 04, 2020 at 05:45:26PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 4 Apr 2020 17:34:53 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> index 6b301afffd11..a1fb2fbdbe7b 100644
> --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> @@ -537,10 +537,8 @@ static int sun8i_ss_probe(struct platform_device *pdev)
> return err;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(ss->dev, "Cannot get SecuritySystem IRQ\n");
> + if (irq < 0)
> return irq;
> - }
>
> ss->reset = devm_reset_control_get(&pdev->dev, NULL);
> if (IS_ERR(ss->reset)) {
> --
> 2.26.0
>

Hello

Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Thanks

\
 
 \ /
  Last update: 2020-04-05 19:57    [W:0.052 / U:27.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site