lkml.org 
[lkml]   [2020]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/4] dt-bindings: iio: light: vcnl4000: Add near-level
On Tue, 31 Mar 2020 15:45:17 -0600
Rob Herring <robh@kernel.org> wrote:

> On Sun, Mar 29, 2020 at 10:25:26AM +0100, Jonathan Cameron wrote:
> > On Wed, 25 Mar 2020 12:09:06 +0100
> > Guido Günther <agx@sigxcpu.org> wrote:
> >
> > > This value indicates when userspace should consider an object
> > > near to the sensor/device.
> > >
> > > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> >
> > I'm fine with this. Note for Rob or other DT people.
> >
> > This is a new generic binding hence no vendor prefix.
>
> Then document in a common place.

Ok.

I guess we need to create a proximity specific binding file.

Documentation/devicetree/bindings/iio/proximity.yaml

Guido, could you do a v4 adding such a file. For now I think
this is pretty much all that is proximity specific.

At somepoint we should convert the subsystem wide iio-bindings.txt
but not today!

Thanks,

Jonathan

>
> >
> > I will ideally want review of both the dt patches though
> > before applying. As we've missed the merge window anyway
> > there is no particular rush.
> >
> > Thanks,
> >
> > Jonathan
> >
> > > ---
> > > .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > index 21ef2eb7a205..ac9e3bb6a505 100644
> > > --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > @@ -25,6 +25,13 @@ properties:
> > > reg:
> > > maxItems: 1
> > >
> > > + near-level:
>
> Perhaps proximity-near-level instead.

Makes sense.

>
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > + description:
> > > + Raw proximity values equal or above this level should be
> > > + considered 'near' to the device (an object is near to the
> > > + sensor).
> > > +
> > > required:
> > > - compatible
> > > - reg
> > > @@ -40,6 +47,7 @@ examples:
> > > light-sensor@51 {
> > > compatible = "vishay,vcnl4200";
> > > reg = <0x51>;
> > > + near-level = <220>;
> > > };
> > > };
> > > ...
> >

\
 
 \ /
  Last update: 2020-04-04 17:02    [W:0.082 / U:2.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site