lkml.org 
[lkml]   [2020]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe()
On Fri, Apr 03, 2020 at 07:14:29PM +0800, Tang Bin wrote:
> When something goes wrong, platform_get_irq() will print an error message,
> so in order to avoid the situation of repeat output,we should remove
> dev_err here.
>
> Changes from v4:
> - rewrite the code, because the code in v4 is wrong, sorry.
>
> Changes form v3:
> - fix the theme writing error.
>
> Changes from v2:
> - modify the theme format and content description.
> - reformat the patch, it's the wrong way to resubmit a new patch that
> should be modified on top of the original. The original piece is:
> https://lore.kernel.org/patchwork/patch/1219611/
>
> Changes from v1:
> - the title has changed, because the description is not very detailed.
> - the code has been modified, because it needs to match the theme.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---

Hello

The changelog should not be in the commit message.
You should set them after the "---" line

Thanks

\
 
 \ /
  Last update: 2020-04-03 20:43    [W:0.042 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site