Messages in this thread |  | | Subject | Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs | From | Joe Perches <> | Date | Fri, 03 Apr 2020 11:38:29 -0700 |
| |
On Fri, 2020-04-03 at 13:47 +0300, Sakari Ailus wrote: > On Fri, Apr 03, 2020 at 01:24:49PM +0300, Laurent Pinchart wrote: > > On Fri, Apr 03, 2020 at 12:11:56PM +0300, Sakari Ailus wrote: > > > Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM > > > pixel formats denoted by 4ccs. The 4cc encoding is the same for both so > > > the same implementation can be used. [] > > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c [] > > > +static noinline_for_stack > > > +char *fourcc_string(char *buf, char *end, const u32 *fourcc, > > > + struct printf_spec spec, const char *fmt) [] > > > + if (fmt[1] != 'c' || fmt[2] != 'c')
This could check outside a format string if the %p4 is at the end of the format string.
printk("%p4", fourcc)
So this should verify
if (!(fmt[1] == 'c' && fmt[2] == 'c'))
|  |