[lkml]   [2020]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5 1/5] PM / EM: add devices to Energy Model

Hi Lukasz,

On 18/03/2020 12:45, Lukasz Luba wrote:
> Add support of other devices into the Energy Model framework not only the
> CPUs. Change the interface to be more unified which can handle other
> devices as well.

thanks for taking care of that. Overall I like the changes in this patch
but it hard to review in details because the patch is too big :/

Could you split this patch into smaller ones?

eg. (at your convenience)

- One patch renaming s/cap/perf/

- One patch adding a new function:

em_dev_register_perf_domain(struct device *dev,
unsigned int nr_states,
struct em_data_callback *cb);


And em_register_perf_domain() using it.

- One converting the em_register_perf_domain() user to

- One adding the different new 'em' functions

- And finally one removing em_register_perf_domain().

> Acked-by: Quentin Perret <>
> Signed-off-by: Lukasz Luba <>
> ---

[ ... ]

> 2. Core APIs
> @@ -70,14 +72,16 @@ CONFIG_ENERGY_MODEL must be enabled to use the EM framework.
> Drivers are expected to register performance domains into the EM framework by
> calling the following API::
> - int em_register_perf_domain(cpumask_t *span, unsigned int nr_states,
> - struct em_data_callback *cb);
> + int em_register_perf_domain(struct device *dev, unsigned int nr_states,
> + struct em_data_callback *cb, cpumask_t *cpus);

Isn't possible to get rid of this cpumask by using
cpufreq_cpu_get() which returns the cpufreq's policy and from their get
the related cpus ?

[ ... ]

<> │ Open source software for ARM SoCs

Follow Linaro: <> Facebook |
<!/linaroorg> Twitter |
<> Blog

 \ /
  Last update: 2020-04-03 18:05    [W:0.218 / U:2.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site