Messages in this thread |  | | Date | Fri, 3 Apr 2020 16:04:38 +0200 (CEST) | From | Julia Lawall <> | Subject | question about drivers/net/ethernet/renesas/ravb_main.c |
| |
Hello,
In the function ravb_hwtstamp_get in ravb_main.c, the following code looks suspicious:
if (priv->tstamp_rx_ctrl & RAVB_RXTSTAMP_TYPE_V2_L2_EVENT) config.rx_filter = HWTSTAMP_FILTER_PTP_V2_L2_EVENT; else if (priv->tstamp_rx_ctrl & RAVB_RXTSTAMP_TYPE_ALL) config.rx_filter = HWTSTAMP_FILTER_ALL; else config.rx_filter = HWTSTAMP_FILTER_NONE;
According to drivers/net/ethernet/renesas/ravb.h, RAVB_RXTSTAMP_TYPE_V2_L2_EVENT is 0x00000002 and RAVB_RXTSTAMP_TYPE_ALL is 0x00000006. Therefore, if the test on RAVB_RXTSTAMP_TYPE_ALL should be true, it will never be reached. How should the code be changed?
thanks, julia
|  |