lkml.org 
[lkml]   [2020]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][V2][next] rtc: ds1307: check for failed memory allocation on wdt
From
Date
On 03/04/2020 10:22, Alexandre Belloni wrote:
> On 03/04/2020 11:45:04+0300, Dan Carpenter wrote:
>> On Thu, Apr 02, 2020 at 04:53:12PM +0200, Alexandre Belloni wrote:
>>>
>>> As stated, I also prefer keeping the watchdog optional and ignore the
>>> error.
>>
>> Hopefully you aren't running out of memory on start up. In current
>> kernels small memory allocations like this never fail so it doesn't
>> really affect runtime. It only silences the NULL dereference static
>> checker warning.
>>
>
> Yes, so the
>
> if (!wdt)
> return;
>
> would be enough instead of introducing unnecessary error handling.
>
OK, I'll send a V3 later today.

\
 
 \ /
  Last update: 2020-04-03 12:01    [W:0.045 / U:2.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site