lkml.org 
[lkml]   [2020]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kbuild: add dummy toolchains to enable all cc-option etc. in Kconfig
Hi Masahiro,

On Fri, 3 Apr 2020 18:02:24 +0900
Masahiro Yamada <masahiroy@kernel.org> wrote:

> Staring v4.18, Kconfig evaluates compiler capabilities, and hides CONFIG
> options your compiler does not support. This works well if you configure
> and build the kernel on the same host machine.
>
> It is inconvenient if you prepare the .config that is carried to a
> different build environment (typically this happens when you package
> the kernel for distros) because using a different compiler potentially
> produces different CONFIG options than the real build environment.
> So, you probably want to make as many options visible as possible.
> In other words, you need to create a super-set of CONFIG options that
> cover any build environment. If some of the CONFIG options turned out
> to be unsupported on the build machine, they are automatically disabled
> by the nature of Kconfig.
>
> However, it is not feasible to get a full-featured compiler for every
> arch.
>
> This issue was discussed here:
>
> https://lkml.org/lkml/2019/12/9/620
>
> Other than distros, savedefconfig is also a problem. Some arch subsytems
> periodically resync defconfig files. If you use a less-capable compiler
> for savedefconfig, options that do not meet 'depends on $(cc-option,...)'
> will be forcibly disabled. So, defconfig && savedefconfig may silently
> change the behavior.
>
> This commit adds a set of dummy toolchains that pretend to support any
> feature.
>
> Most of compiler features are tested by cc-option, which simply checks
> the exit code of $(CC). The dummy tools are just a shell script that
> exits with 0 in most cases. So, $(cc-option, ...) is evaluated as 'y'.
>
> There are more complicated checks such as:
>
> scripts/gcc-x86_{32,64}-has-stack-protector.sh
> scripts/gcc-plugin.sh
> scripts/tools-support-relr.sh
>
> I tried my best to implement the dummy scripts to pass all checks.
>
> From the top directory of the source tree, you can do:
>
> $ make CROSS_COMPILE=scripts/dummy-tools/ oldconfig
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

look good to me

Reviewed-by: Philipp Rudo <prudo@linux.ibm.com>

Thanks a lot
Philipp

\
 
 \ /
  Last update: 2020-04-03 11:48    [W:0.058 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site