lkml.org 
[lkml]   [2020]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][next] rtc: ds1307: check for failed memory allocation on wdt
On Thu, Apr 02, 2020 at 02:14:41PM +0100, Colin King wrote:
> @@ -1979,9 +1984,9 @@ static int ds1307_probe(struct i2c_client *client,
>
> ds1307_hwmon_register(ds1307);
> ds1307_clks_register(ds1307);
> - ds1307_wdt_register(ds1307);
> + err = ds1307_wdt_register(ds1307);
>
> - return 0;
> + return err;
>
> exit:
> return err;

This bit is weird. I guess just delete the "return 0;" without
introducing a new "return err;".

regards,
dan carpenter

\
 
 \ /
  Last update: 2020-04-03 10:42    [W:0.063 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site