lkml.org 
[lkml]   [2020]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 4/9] perf tools: Maintain cgroup hierarchy
Hi Arnaldo,

On Fri, Apr 3, 2020 at 9:36 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> Em Wed, Mar 25, 2020 at 09:45:31PM +0900, Namhyung Kim escreveu:
> > Each cgroup is kept in the perf_env's cgroup_tree sorted by the cgroup
> > id. Hist entries have cgroup id can compare it directly and later it
> > can be used to find a group name using this tree.
>
> This one breaks the 'perf test python' test, I fixed it adding this
> patch before your series:

Thanks a lot for fixing this and taking care of the whole thing!
Namhyung


> From ea3c4ab73cb2ea2960bba6894560b1ef91e69737 Mon Sep 17 00:00:00 2001
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> Date: Fri, 3 Apr 2020 09:29:52 -0300
> Subject: [PATCH 1/1] perf python: Include rwsem.c in the pythong biding
>
> We'll need it for the cgroup patches, and its better to have it in a
> separate patch in case we need to later revert the cgroup patches.
>
> I.e. without this we have:
>
> [root@five ~]# perf test -v python
> 19: 'import perf' in python :
> --- start ---
> test child forked, pid 148447
> Traceback (most recent call last):
> File "<stdin>", line 1, in <module>
> ImportError: /tmp/build/perf/python/perf.cpython-37m-x86_64-linux-gnu.so: undefined symbol: down_write
> test child finished with -1
> ---- end ----
> 'import perf' in python: FAILED!
> [root@five ~]#
>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/util/python-ext-sources | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/python-ext-sources b/tools/perf/util/python-ext-sources
> index e7279ea6043a..a9d9c142eb7c 100644
> --- a/tools/perf/util/python-ext-sources
> +++ b/tools/perf/util/python-ext-sources
> @@ -34,3 +34,4 @@ util/string.c
> util/symbol_fprintf.c
> util/units.c
> util/affinity.c
> +util/rwsem.c
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2020-04-04 03:30    [W:0.037 / U:4.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site