lkml.org 
[lkml]   [2020]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/7] clocksource: Add Tegra186 timers support
From
Date
03.04.2020 23:51, Dmitry Osipenko пишет:
> 03.04.2020 23:22, Thierry Reding пишет:
> ...
>> +static irqreturn_t tegra186_timer_irq(int irq, void *data)
>> +{
>> + struct tegra186_timer *tegra = data;
>> +
>> + if (watchdog_active(&tegra->wdt->base)) {
>> + tegra186_wdt_disable(tegra->wdt);
>> + tegra186_wdt_enable(tegra->wdt);
>> + }
>
> Shouldn't this return IRQ_NONE if watchdog is inactive?
>
>> + return IRQ_HANDLED;
>> +}
>

Could you please explain why this interrupt handler is needed at all?
Shouldn't the watchdog's core take care of the pinging?

\
 
 \ /
  Last update: 2020-04-03 23:07    [W:0.111 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site