lkml.org 
[lkml]   [2020]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] perf script: remove unneeded conversion to bool
From
Date
On Sun, 2020-04-26 at 20:31 +0800, Zou Wei wrote:
> This issue was detected by using the Coccinelle software:
>
> tools/perf/builtin-script.c:3285:48-53: WARNING: conversion to bool not needed here
> tools/perf/builtin-script.c:2839:36-41: WARNING: conversion to bool not needed here
>
> The conversion to bool is unneeded, remove it
[]
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
[]
> @@ -2836,7 +2836,7 @@ static int parse_output_fields(const struct option *opt __maybe_unused,
> break;
> }
> if (i == imax && strcmp(tok, "flags") == 0) {
> - print_flags = change == REMOVE ? false : true;
> + print_flags = change == REMOVE;

Read the deleted code above this again.

(you have inverted the logic)

> continue;
> }
> if (i == imax) {
> @@ -3282,7 +3282,7 @@ static char *get_script_path(const char *script_root, const char *suffix)
>
> static bool is_top_script(const char *script_path)
> {
> - return ends_with(script_path, "top") == NULL ? false : true;
> + return ends_with(script_path, "top") == NULL;

and here.


\
 
 \ /
  Last update: 2020-04-26 23:00    [W:0.071 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site