lkml.org 
[lkml]   [2020]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 5/9] KVM: X86: Refresh CPUID once guest XSS MSR changes
On Sat, Apr 25, 2020 at 03:19:24PM +0200, Paolo Bonzini wrote:
> On 23/04/20 19:34, Sean Christopherson wrote:
> >> if (!kvm_cpu_cap_has(X86_FEATURE_XSAVES))
> >> supported_xss = 0;
> >> + else
> >> + supported_xss = host_xss & KVM_SUPPORTED_XSS;
> > Silly nit: I'd prefer to invert the check, e.g.
> >
> > if (kvm_cpu_cap_has(X86_FEATURE_XSAVES))
> > supported_xss = host_xss & KVM_SUPPORTED_XSS;
> > else
> > supported_xss = 0;
> >
>
> Also a nit: Linux coding style should be
>
> supported_xss = 0;
> if (kvm_cpu_cap_has(X86_FEATURE_XSAVES))
> supported_xss = host_xss & KVM_SUPPORTED_XSS;
>
> Paolo
Ah, I should follow the coding style, thank you Paolo!

\
 
 \ /
  Last update: 2020-04-26 17:01    [W:0.168 / U:0.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site