lkml.org 
[lkml]   [2020]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/radeon: cleanup coding style a bit
From
Date
Am 26.04.20 um 15:12 schrieb Bernard Zhao:
> Maybe no need to check ws before kmalloc, kmalloc will check
> itself, kmalloc`s logic is if ptr is NULL, kmalloc will just
> return
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

I'm wondering why the automated scripts haven't found that one before.

> ---
> drivers/gpu/drm/radeon/atom.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c
> index 2c27627b6659..f15b20da5315 100644
> --- a/drivers/gpu/drm/radeon/atom.c
> +++ b/drivers/gpu/drm/radeon/atom.c
> @@ -1211,8 +1211,7 @@ static int atom_execute_table_locked(struct atom_context *ctx, int index, uint32
> SDEBUG("<<\n");
>
> free:
> - if (ws)
> - kfree(ectx.ws);
> + kfree(ectx.ws);
> return ret;
> }
>

\
 
 \ /
  Last update: 2020-04-26 15:19    [W:0.068 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site