Messages in this thread |  | | Date | Sun, 26 Apr 2020 14:56:47 +0200 | From | Paul Cercueil <> | Subject | Re: [PATCH v7 08/12] arm: dts: s5pv210: Add node for SGX 540 |
| |
Le ven. 24 avril 2020 à 22:34, H. Nikolaus Schaller <hns@goldelico.com> a écrit : > From: Jonathan Bakker <xc-racer2@live.ca> > > All s5pv210 devices have a PowerVR SGX 540 (revision 120) attached. > > There is no external regulator for it so it can be enabled by default. > > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > arch/arm/boot/dts/s5pv210.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/s5pv210.dtsi > b/arch/arm/boot/dts/s5pv210.dtsi > index 2ad642f51fd9..abbdda205c1b 100644 > --- a/arch/arm/boot/dts/s5pv210.dtsi > +++ b/arch/arm/boot/dts/s5pv210.dtsi > @@ -512,6 +512,19 @@ vic3: interrupt-controller@f2300000 { > #interrupt-cells = <1>; > }; > > + gpu: gpu@f3000000 { > + compatible = "samsung,s5pv210-sgx540-120"; > + reg = <0xf3000000 0x10000>; > + interrupt-parent = <&vic2>; > + interrupts = <10>; > + clock-names = "core"; > + clocks = <&clocks CLK_G3D>; > + > + assigned-clocks = <&clocks MOUT_G3D>, <&clocks DOUT_G3D>; > + assigned-clock-rates = <0>, <66700000>; > + assigned-clock-parents = <&clocks MOUT_MPLL>;
What are these clocks for, and why are they reparented / reclocked?
Shouldn't they be passed to 'clocks' as well?
-Paul
> + }; > + > fimd: fimd@f8000000 { > compatible = "samsung,s5pv210-fimd"; > interrupt-parent = <&vic2>; > -- > 2.25.1 >
|  |