lkml.org 
[lkml]   [2020]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: Fw: Arm CryptoCell driver -- default Y, even on machines where it is obviously useless
Date
Hi Ard,

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Sunday, 19 April 2020 11:55
>
> > > > -----Original Message-----
> > > > From: Pavel Machek <pavel@ucw.cz>
> > > > Sent: Saturday, 18 April 2020 13:44
> > > >
> > > > Hi!
> > > >
> > > > I'm configuring kernel for x86, and I get offered
> HW_RANDOM_CCTRNG
> > > > with default=Y, and help text suggesting I should enable it.
> > > >
> > > > That's... two wrong suggestions, right?
> > > >
> > > > Best regards,
> > > > Pavel
> > ...
> > > ________________________________________
> > > From: Hadar Gat <Hadar.Gat@arm.com>
> > > Sent: Saturday, April 18, 2020 11:31 PM
> > >
> > > Hi Pavel,
> > > I think you got it right..
> > > Indeed, Arm CryptoCell CCTRNG driver couldn't be used and obviously
> useless if the Arm CryptoCell HW does not exist in the system.
> >
> > There's a delicate point here though - CryptoCell is an independent
> > hardware block, it is not tied to a particular CPU architecture.
> > There are SoCs with none-Arm architecture CPU using it.
> >
> > So I would say whatever the answer is, it should be the same for any
> > generic embedded style HW block.
> >
> > And the help text is not architecture specific anyway, is it not..?
> >
>
> Both the default y and and the help text are indeed incorrect. This should be
> fixed. We don't enable device drivers by default, and definitely not as as
> builtins. A conditional default m could be acceptable if the condition is
> sufficiently narrow.

On one hand I totally agree with that and think the default should be N.
On the other hand, most of the HW_RANDOM drivers set the default to HW_RANDOM
and it doesn't make sense to me to do something different than almost every other HW RANDOM device.
Do I miss something here?

>
> While at it, could we add a depends on CONFIG_OF since this code is
> definitely unusable on non-DT systems.

\
 
 \ /
  Last update: 2020-04-26 14:50    [W:0.066 / U:6.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site