lkml.org 
[lkml]   [2020]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: BUG 5.5.6, from patch "cpu/SMT: Fix x86 link error without CONFIG_SYSFS"
Date
Holger,

Holger Schurig <holger.schurig@advantech.de> writes:

> if one compiled kernel 5.6.6 with CONFIG_HOTPLUG_CPU=n, then the
> compilation will fail. The reason is your patch, which introduces
> this:

> +int cpuhp_smt_disable(enum cpuhp_smt_control ctrlval)

It would have been more helpful to provide the actual commit SHA instead
of copying tons of patch code.

> It happens that cpu_down_maps_locked is only defined when
> CONFIG_HOTPLUG_CPU=y, but not otherwise.

Right.

> On my embedded target I so far had the CPU hotplugging off. After all,
> the CPU is physically soldered, there will never be a hotplugging
> happen.

CPU hotplug is used for far more than physical hotplug.

SMT control depends on it in order to apply speculation mitigations,
hibernation requires working CPU hotplug as well.

As the speculation mess requires SMT control we more or less have to
make CPU hotplug mandatory on x86...

Thanks,

tglx

\
 
 \ /
  Last update: 2020-04-26 12:40    [W:0.050 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site